From 3c7a8cff27a1d2c93f08b526da662939db11266f Mon Sep 17 00:00:00 2001
From: ergosteur <1992147+ergosteur@users.noreply.github.com>
Date: Thu, 6 Aug 2026 16:58:40 +0000
Subject: [PATCH] Retire the OVA/OVF importers to unused/

Proxmox imports OVA/OVF natively now through a storage with the "import"
content type, or qm importovf. The built-in path also handles per-storage disk
format conversion, which neither script did.

Recorded the known bugs in each header rather than fixing them, since nothing
will run these again: import-ova-pve.py imports every VMDK but only attaches
disk-0, leaving multi-disk appliances partly orphaned, and assumes a
vm-<vmid>-disk-N name that not every storage type uses;
import-ova-to-proxmox.sh passes --format qcow2 unconditionally, which fails on
ZFS and LVM-thin.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---
 import-ova-pve.py => unused/import-ova-pve.py       | 13 +++++++++++++
 .../import-ova-to-proxmox.sh                        | 12 ++++++++++++
 2 files changed, 25 insertions(+)
 rename import-ova-pve.py => unused/import-ova-pve.py (89%)
 rename import-ova-to-proxmox.sh => unused/import-ova-to-proxmox.sh (91%)

diff --git a/import-ova-pve.py b/unused/import-ova-pve.py
similarity index 89%
rename from import-ova-pve.py
rename to unused/import-ova-pve.py
index a2459d8..d3738f8 100755
--- a/import-ova-pve.py
+++ b/unused/import-ova-pve.py
@@ -1,4 +1,17 @@
 #!/usr/bin/env python3
+#
+# RETIRED. Kept for reference only.
+#
+# Proxmox imports OVA/OVF natively now, via a storage with the "import" content
+# type: upload the .ova there and use Create VM > Import, or `qm importovf`.
+# The built-in path handles disk format conversion per storage type, which this
+# script did not.
+#
+# Two known bugs, left unfixed since the script is retired:
+#   * every VMDK is imported in the loop, but only vm-<vmid>-disk-0 is ever
+#     attached, so multi-disk appliances leave the rest orphaned
+#   * the disk name is assumed to be vm-<vmid>-disk-N, which does not hold on
+#     every storage type
 
 import os
 import sys
diff --git a/import-ova-to-proxmox.sh b/unused/import-ova-to-proxmox.sh
similarity index 91%
rename from import-ova-to-proxmox.sh
rename to unused/import-ova-to-proxmox.sh
index 0234267..4d75e5d 100755
--- a/import-ova-to-proxmox.sh
+++ b/unused/import-ova-to-proxmox.sh
@@ -1,4 +1,16 @@
 #!/bin/bash
+#
+# RETIRED. Kept for reference only.
+#
+# Proxmox imports OVA/OVF natively now, via a storage with the "import" content
+# type: upload the .ova there and use Create VM > Import, or `qm importovf`.
+# The built-in path handles disk format conversion per storage type, which this
+# script did not.
+#
+# Known bug, left unfixed since the script is retired: importdisk is called with
+# --format qcow2 unconditionally, which fails on ZFS and LVM-thin storages that
+# do not take a format argument.
+
 set -euo pipefail
 
 # === OVF/OVA Importer for Proxmox ===