ergosteur/instaarchive-viewer
1
0
Fork 0
mirror of https://github.com/ergosteur/instaarchive-viewer.git synced 2026-07-04 11:07:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve Firefox media warnings by improving video cleanup

Browse Source
This commit is contained in:
ergosteur
2026-03-07 02:30:46 -05:00
parent d396b356be
commit d7c13ecc19
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/App.tsx
View File

@@ -451,7 +451,9 @@ const VideoThumbnail = ({ url, className }: { url: string; className?: string })
const cleanup = () => { const cleanup = () => {
video.removeEventListener('loadedmetadata', handleLoadedMetadata); video.removeEventListener('loadedmetadata', handleLoadedMetadata);
video.removeEventListener('seeked', handleSeeked); video.removeEventListener('seeked', handleSeeked);
video.src = ''; video.load(); // Using removeAttribute is safer than src = '' to stop loading without warnings
video.removeAttribute('src');
video.load();
}; };
video.addEventListener('loadedmetadata', handleLoadedMetadata); video.addEventListener('loadedmetadata', handleLoadedMetadata);
@@ -485,6 +487,9 @@ const MediaRenderer = ({ file, className, isFullView }: { file: MediaFile; class
const sizingClass = isFullView ? "w-full h-auto block" : "w-full h-full object-cover"; const sizingClass = isFullView ? "w-full h-auto block" : "w-full h-full object-cover";
const mediaStyle = { transform: 'translateZ(0)' }; const mediaStyle = { transform: 'translateZ(0)' };
// Guard against empty URLs
if (!file.url) return <div className={cn("bg-gray-100 flex items-center justify-center", sizingClass)}><Play size={24} className="text-gray-300" /></div>;
if (file.type === 'video') { if (file.type === 'video') {
return ( return (
<div className="relative w-full h-full flex items-center justify-center group/video"> <div className="relative w-full h-full flex items-center justify-center group/video">