ergosteurandClaude Opus 5
1d86fa3583
Security - Fix path traversal in GET /api/archives/:name/files. Express decodes route params after segment matching, so `..%2f..%2fetc` escaped ARCHIVES_DIR and returned a recursive listing of arbitrary directories. - Add CSP and baseline security headers; disable x-powered-by. - Stop baking GEMINI_API_KEY into the client bundle (the SDK was unused). - Run the container as `node` instead of root. Performance - Add a directory-mtime-keyed archive index, warmed in the background and persisted. Listing 110k files went from ~52s to ~0.1s; the largest archive (24k files) serves in ~0.3s. Per-file stat over CIFS costs ~1.4ms and does not parallelise, so it is now done once rather than per request. - Build media URLs from the File directly instead of `new Blob([await file.arrayBuffer()])`, which read every media file fully into memory (a 20GB archive tried to become 20GB of resident blobs). - Track and revoke object URLs; previously none were ever revoked. - Give `requestThumbnail` a stable identity so a completed thumbnail stops re-running the effect in every mounted thumbnail. - Namespace IndexedDB keys so listing archives no longer deserializes every cached thumbnail blob, and thumbnails no longer collide across archives. - Serve real file sizes: RemoteArchiveFile was constructed with size 0, which silently disabled high-res thumbnailing for every server archive. Correctness - Local archives cached media as blob: URLs, which die with the document, so a cached local archive restored as an archive of broken images. Media now carries a stable path and is rehydrated from a persisted directory handle (File System Access API), falling back to re-prompting for the folder. - Fix permalinks: the URL-writing effect erased ?a= on mount before the archive list arrived to consume it, so deep links never resolved. - Make cache invalidation detect nested changes via a directory signature. - Add an error boundary and tolerate unparseable dates, which previously threw a RangeError and blanked the app. - Default video to muted so autoplay is not blocked by Safari/Firefox. Features - Fold sidecar directories into their base profile: `<user> - reels`, `story - <user>` and `story highlights - <user> - <title>` now appear as reels, the story ring and Instagram-style highlight circles rather than as separate archives. Housekeeping - Add @types/react; React was previously type-checked against its JavaScript source, so `npm run lint` gave almost no type safety on components. - Vendor fonts and PWA icons locally; the app made third-party CDN requests despite advertising offline support and local-only processing. - Drop unused better-sqlite3 (a native module that broke `npm install`). - Add vitest with 36 tests over the filename and directory-naming rules. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011uBWhwV3wFQ5MBCcMHHem7
90 lines
3.4 KiB
TypeScript
90 lines
3.4 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
||
import { classifyDirectory, groupArchiveDirectories } from './archive-grouping';
|
||
|
||
describe('classifyDirectory', () => {
|
||
it('treats a bare profile directory as the base', () => {
|
||
expect(classifyDirectory('4utumn07')).toEqual({
|
||
owner: '4utumn07',
|
||
source: { kind: 'posts', dir: '4utumn07' },
|
||
});
|
||
});
|
||
|
||
it('recognises a reels sidecar', () => {
|
||
expect(classifyDirectory('4utumn07 - reels')).toEqual({
|
||
owner: '4utumn07',
|
||
source: { kind: 'reels', dir: '4utumn07 - reels' },
|
||
});
|
||
});
|
||
|
||
it('recognises a stories sidecar', () => {
|
||
expect(classifyDirectory('story - dawn_petal')).toEqual({
|
||
owner: 'dawn_petal',
|
||
source: { kind: 'stories', dir: 'story - dawn_petal' },
|
||
});
|
||
});
|
||
|
||
it('splits highlight owner from title', () => {
|
||
const { owner, source } = classifyDirectory('story highlights - 4utumn07 - Sunstory');
|
||
expect(owner).toBe('4utumn07');
|
||
expect(source.kind).toBe('highlight');
|
||
expect(source.title).toBe('Sunstory');
|
||
});
|
||
|
||
it.each([
|
||
['story highlights - theoldlyricmuseinsta - 💙1999-2005 era', 'theoldlyricmuseinsta', '💙1999-2005 era'],
|
||
['story highlights - member_theworld - [Bracket]', 'member_theworld', '[Bracket]'],
|
||
['story highlights - official_band - Tour Schedule', 'official_band', 'Tour Schedule'],
|
||
['story highlights - 4utumn07 - Sketching⠀', '4utumn07', 'Sketching⠀'],
|
||
['story highlights - official_band - A.B.C', 'official_band', 'A.B.C'],
|
||
])('handles real-world title %s', (dir, owner, title) => {
|
||
const result = classifyDirectory(dir);
|
||
expect(result.owner).toBe(owner);
|
||
expect(result.source.title).toBe(title);
|
||
});
|
||
|
||
it('keeps titles containing " - " intact', () => {
|
||
// The username is matched as a non-space run, so only the first separator
|
||
// splits owner from title.
|
||
const { owner, source } = classifyDirectory('story highlights - user - a - b');
|
||
expect(owner).toBe('user');
|
||
expect(source.title).toBe('a - b');
|
||
});
|
||
|
||
it('does not mistake a profile with spaces for a sidecar', () => {
|
||
expect(classifyDirectory('Heejin_Bubble heejinmedia').source.kind).toBe('posts');
|
||
});
|
||
});
|
||
|
||
describe('groupArchiveDirectories', () => {
|
||
const dirs = [
|
||
'4utumn07',
|
||
'4utumn07 - reels',
|
||
'story - 4utumn07',
|
||
'story highlights - 4utumn07 - Sunstory',
|
||
'story highlights - 4utumn07 - Sketching⠀',
|
||
'kestrelsings',
|
||
];
|
||
|
||
it('folds sidecars into their base profile', () => {
|
||
const groups = groupArchiveDirectories(dirs);
|
||
expect([...groups.keys()].sort()).toEqual(['4utumn07', 'kestrelsings']);
|
||
expect(groups.get('4utumn07')).toHaveLength(5);
|
||
expect(groups.get('kestrelsings')).toHaveLength(1);
|
||
});
|
||
|
||
it('orders sources posts, reels, stories, then highlights by title', () => {
|
||
const sources = groupArchiveDirectories(dirs).get('4utumn07')!;
|
||
expect(sources.map(s => s.kind)).toEqual(['posts', 'reels', 'stories', 'highlight', 'highlight']);
|
||
expect(sources.slice(3).map(s => s.title)).toEqual(['Sketching⠀', 'Sunstory']);
|
||
});
|
||
|
||
it('still groups a sidecar whose base profile is missing', () => {
|
||
const groups = groupArchiveDirectories(['story - orphan']);
|
||
expect(groups.get('orphan')).toEqual([{ kind: 'stories', dir: 'story - orphan' }]);
|
||
});
|
||
|
||
it('is stable for an empty archive root', () => {
|
||
expect(groupArchiveDirectories([]).size).toBe(0);
|
||
});
|
||
});
|