mirror of
https://github.com/ergosteur/ergo-proxmox-scripts.git
synced 2026-10-28 13:00:37 -04:00
ergosteurandClaude Opus 5
ab0b4d7d0f
shellcheck flagged three things, one of which was worth acting on beyond silencing it. echo was emitting a script fragment containing a literal \n meant for the generated code, not for this shell. Bash's echo leaves it alone by default, but the handling of backslashes is implementation-defined and xpg_echo would have expanded it and corrupted the fragment. printf '%s\n' instead. The discover_* functions were dispatched as "discover_$distro", which reads as dead code to shellcheck and to anyone grepping for a caller. An explicit case dispatch replaces it, which is what SC2317 was really complaining about. The two remaining SC2016 hits are intentional single quotes, one a sed address matching a literal $DISTRO_CHOICE and one emitting code, and are annotated rather than fixed. Also reject an unknown --distro. It previously filtered every distro out and reported "all pins are already current" with exit 0, so a typo looked like a clean run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>